Skip to content

Avoid method hiding warning#4059

Merged
dkachuma merged 3 commits into
developfrom
dkachuma/avoid-function-hiding
May 16, 2026
Merged

Avoid method hiding warning#4059
dkachuma merged 3 commits into
developfrom
dkachuma/avoid-function-hiding

Conversation

@dkachuma
Copy link
Copy Markdown
Contributor

@dkachuma dkachuma commented May 14, 2026

On GPU builds I was getting many warnings of the form

src/coreComponents/constitutiveDrivers/fluid/multiFluid/PVTDriver.hpp(50): warning #997-D: function "geos::ExecutableGroup::execute(geos::real64, geos::real64, geos::integer, geos::integer, geos::real64, geos::DomainPartition &)" is hidden by "geos::PVTDriver::execute" -- virtual function override intended?
    bool execute() override;
         ^

This change makes it more explicit to avoid this warning.

@dkachuma dkachuma self-assigned this May 14, 2026
@dkachuma dkachuma added type: cleanup / refactor Non-functional change (NFC) ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs labels May 14, 2026
@dkachuma dkachuma merged commit 299508e into develop May 16, 2026
21 checks passed
@dkachuma dkachuma deleted the dkachuma/avoid-function-hiding branch May 16, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

Assignees

@dkachuma dkachuma

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkachuma @jhuang2601